Skip to content

use assertSame in tests#25

Merged
loks0n merged 4 commits intomainfrom
chore-assertSame
Jan 15, 2026
Merged

use assertSame in tests#25
loks0n merged 4 commits intomainfrom
chore-assertSame

Conversation

@hmacr
Copy link
Contributor

@hmacr hmacr commented Jan 6, 2026 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Tests
    • Strengthened assertions across the connection pool test suite by switching loose equality checks to strict identity checks, tightened comparisons for counts, strings and telemetry values, and made one exception expectation explicit—improving test rigor and reliability for adapter, scope, group and pool behaviors.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 6, 2026 •
edited
Loading

Walkthrough

This pull request updates tests across four files (tests/Pools/Adapter/SwooleTest.php, tests/Pools/Scopes/ConnectionTestScope.php, tests/Pools/Scopes/GroupTestScope.php, tests/Pools/Scopes/PoolTestScope.php) by replacing loose equality assertions (assertEquals) with strict identity assertions (assertSame). Several expected values were adjusted (including a change from null to '' in a connection ID expectation) and an explicit expectException was added in one pool pop test. No control flow, public API, or production code changes were made.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: converting PHPUnit assertions from assertEquals to assertSame across multiple test files.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d0ef853 and 14e78b0.

📒 Files selected for processing (1)
  • tests/Pools/Scopes/ConnectionTestScope.php
🧰 Additional context used
🧬 Code graph analysis (1)
tests/Pools/Scopes/ConnectionTestScope.php (1)
src/Pools/Connection.php (3)
  • getID (29-32)
  • setID (38-42)
  • Connection (10-105)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Tests
🔇 Additional comments (6)
tests/Pools/Scopes/ConnectionTestScope.php (6)

24-34: Good fix: Corrected expected value and stricter assertion.

The change from null to '' correctly matches the Connection class implementation where $id is typed as string with default value ''. The switch to assertSame ensures strict type checking.

36-46: LGTM!

Consistent with the correction in testConnectionGetID - the default value expectation and strict assertion are correct.

48-66: LGTM!

Using assertSame for string resource comparisons ensures type-safe equality checks.

95-95: LGTM!

Strict assertion for pool name comparison.

99-122: LGTM!

Using assertSame for integer count comparisons ensures strict type checking, preventing potential false positives from loose equality.

133-165: LGTM!

All assertions correctly updated to strict comparisons for both integer counts and string resource values.

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@loks0n loks0n merged commit 74ba7dc into main Jan 15, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@loks0n loks0n loks0n approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hmacr @loks0n